From: Simon Marchi <simon.marchi@ericsson.com>
Date: Mon, 27 Jul 2015 19:49:24 +0000 (-0400)
Subject: gdb.mi/mi-pending.c: Return NULL instead of nothing in thread function
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=13e1dec8960122ec0329f74e5915503e14db5ea2;p=binutils-gdb.git

gdb.mi/mi-pending.c: Return NULL instead of nothing in thread function

Using gcc 5.2 (maybe other versions as well), building mi-pending.c gives
these warnings:

	./gdb.mi/mi-pending.c: In function ‘thread_func’:
	./gdb.mi/mi-pending.c:34:5: warning: ‘return’ with no value, in function returning non-void
	     return;
	     ^
	./gdb.mi/mi-pending.c:38:5: warning: ‘return’ with no value, in function returning non-void
	     return;
	     ^
gdb_compile_pthreads assumes that the build was successful only if there
is no output. These warnings therefore make gdb_compile_pthreads think
that the build failed, and the test doesn't run.

The easy fix is to replace the "return" with "return NULL".  I am
pushing this as obvious.

gdb/testsuite/ChangeLog:

	* gdb.mi/mi-pending.c (thread_func): Replace return with return
	NULL.
---

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 73bc2b65b15..fd7c09c0bab 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2015-07-27  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* gdb.mi/mi-pending.c (thread_func): Replace return with return NULL.
+
 2015-07-27  Simon Marchi  <simon.marchi@ericsson.com>
 
 	* gdb.mi/mi-watch.exp (test_watchpoint_triggering): Remove xfail.
diff --git a/gdb/testsuite/gdb.mi/mi-pending.c b/gdb/testsuite/gdb.mi/mi-pending.c
index 248c7a8b0d7..2f3464e2eef 100644
--- a/gdb/testsuite/gdb.mi/mi-pending.c
+++ b/gdb/testsuite/gdb.mi/mi-pending.c
@@ -31,11 +31,11 @@ thread_func (void* arg)
 
   h = dlopen (libname, RTLD_LAZY);  /* set breakpoint here */
   if (h == NULL)
-    return;
+    return NULL;
 
   p_func = dlsym (h, "pendfunc3");
   if (p_func == NULL)
-    return;
+    return NULL;
 
   (*p_func) ();
 }