From: Gabe Black Date: Wed, 5 Feb 2020 02:41:05 +0000 (-0800) Subject: cpu: Remove the ancient do_quiesce config option. X-Git-Tag: v20.1.0.0~630 X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=1425640edaa74429b8116ce8758cb9f72d6c90c4;p=gem5.git cpu: Remove the ancient do_quiesce config option. This option has existed for a very long time, defaults to True, and is not used in any of the checked in configs. It enables the "quiesce" mechanism, originally just pseudo instructions, and it's not clear why you'd ever want to turn it off. Change-Id: I92c7e5af22157e8435c7326634857d30bb5d7254 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/25143 Reviewed-by: Anthony Gutierrez Reviewed-by: Matthew Poremba Maintainer: Anthony Gutierrez Tested-by: kokoro --- diff --git a/src/cpu/BaseCPU.py b/src/cpu/BaseCPU.py index ab70d1d7f..e487cbb6b 100644 --- a/src/cpu/BaseCPU.py +++ b/src/cpu/BaseCPU.py @@ -149,7 +149,6 @@ class BaseCPU(ClockedObject): "enable statistics pseudo instructions") profile = Param.Latency('0ns', "trace the kernel stack") - do_quiesce = Param.Bool(True, "enable quiesce instructions") wait_for_remote_gdb = Param.Bool(False, "Wait for a remote GDB connection"); diff --git a/src/cpu/thread_context.cc b/src/cpu/thread_context.cc index de6997a23..9b93d7549 100644 --- a/src/cpu/thread_context.cc +++ b/src/cpu/thread_context.cc @@ -130,9 +130,6 @@ ThreadContext::compare(ThreadContext *one, ThreadContext *two) void ThreadContext::quiesce() { - if (!getCpuPtr()->params()->do_quiesce) - return; - DPRINTF(Quiesce, "%s: quiesce()\n", getCpuPtr()->name()); suspend(); @@ -146,9 +143,6 @@ ThreadContext::quiesceTick(Tick resume) { BaseCPU *cpu = getCpuPtr(); - if (!cpu->params()->do_quiesce) - return; - EndQuiesceEvent *quiesceEvent = getQuiesceEvent(); cpu->reschedule(quiesceEvent, resume, true);