From: ajreynol <andrew.j.reynolds@gmail.com>
Date: Thu, 15 Jun 2017 15:49:51 +0000 (-0500)
Subject: Fix relevant domain for datatypes, fixes bug 824.
X-Git-Tag: cvc5-1.0.0~5774
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=146a85c4f00f57eb753a6b81e9d8b2eafe013032;p=cvc5.git

Fix relevant domain for datatypes, fixes bug 824.
---

diff --git a/src/theory/quantifiers/inst_strategy_e_matching.cpp b/src/theory/quantifiers/inst_strategy_e_matching.cpp
index a197e057e..2cef4f6a1 100644
--- a/src/theory/quantifiers/inst_strategy_e_matching.cpp
+++ b/src/theory/quantifiers/inst_strategy_e_matching.cpp
@@ -671,7 +671,9 @@ bool FullSaturation::process( Node f, bool fullEffort ){
         Trace("inst-alg") << "-> Ground term instantiate " << f << "..." << std::endl;
       }
       Assert( rd!=NULL );
+      Trace("inst-alg-debug") << "Compute relevant domain..." << std::endl;
       rd->compute();
+      Trace("inst-alg-debug") << "...finished" << std::endl;
       unsigned final_max_i = 0;
       std::vector< unsigned > maxs;
       std::vector< bool > max_zero;
diff --git a/src/theory/quantifiers/relevant_domain.cpp b/src/theory/quantifiers/relevant_domain.cpp
index f7bac23e2..63231dec7 100644
--- a/src/theory/quantifiers/relevant_domain.cpp
+++ b/src/theory/quantifiers/relevant_domain.cpp
@@ -152,6 +152,7 @@ void RelevantDomain::compute(){
 }
 
 void RelevantDomain::computeRelevantDomain( Node q, Node n, bool hasPol, bool pol ) {
+  Trace("rel-dom-debug") << "Compute relevant domain " << n << "..." << std::endl;
   Node op = d_qe->getTermDatabase()->getMatchOperator( n );
   for( unsigned i=0; i<n.getNumChildren(); i++ ){
     if( !op.isNull() ){
@@ -191,6 +192,7 @@ void RelevantDomain::computeRelevantDomain( Node q, Node n, bool hasPol, bool po
       }
     }
   }
+  Trace("rel-dom-debug") << "...finished Compute relevant domain " << n << std::endl;
 }
 
 void RelevantDomain::computeRelevantDomainOpCh( RDomain * rf, Node n ) {
@@ -238,43 +240,45 @@ void RelevantDomain::computeRelevantDomainLit( Node q, bool hasPol, bool pol, No
         d_rel_dom_lit[hasPol][pol][n].d_rd[1] = NULL;
       }else{
         //solve the inequality for one/two variables, if possible
-        std::map< Node, Node > msum;
-        if( QuantArith::getMonomialSumLit( n, msum ) ){
-          Node var;
-          Node var2;
-          bool hasNonVar = false;
-          for( std::map< Node, Node >::iterator it = msum.begin(); it != msum.end(); ++it ){
-            if( !it->first.isNull() && it->first.getKind()==INST_CONSTANT ){
-              if( var.isNull() ){
-                var = it->first;
-              }else if( var2.isNull() ){
-                var2 = it->first;
+        if( n[0].getType().isReal() ){
+          std::map< Node, Node > msum;
+          if( QuantArith::getMonomialSumLit( n, msum ) ){
+            Node var;
+            Node var2;
+            bool hasNonVar = false;
+            for( std::map< Node, Node >::iterator it = msum.begin(); it != msum.end(); ++it ){
+              if( !it->first.isNull() && it->first.getKind()==INST_CONSTANT ){
+                if( var.isNull() ){
+                  var = it->first;
+                }else if( var2.isNull() ){
+                  var2 = it->first;
+                }else{
+                  hasNonVar = true;
+                }
               }else{
                 hasNonVar = true;
               }
-            }else{
-              hasNonVar = true;
             }
-          }
-          if( !var.isNull() ){
-            if( var2.isNull() ){
-              //single variable solve
-              Node veq_c;
-              Node val;
-              int ires = QuantArith::isolate( var, msum, veq_c, val, n.getKind() );
-              if( ires!=0 ){
-                if( veq_c.isNull() ){
-                  r_add = val;
-                  varLhs = (ires==1);
-                  d_rel_dom_lit[hasPol][pol][n].d_rd[0] = getRDomain( q, var.getAttribute(InstVarNumAttribute()), false );
-                  d_rel_dom_lit[hasPol][pol][n].d_rd[1] = NULL;
+            if( !var.isNull() ){
+              if( var2.isNull() ){
+                //single variable solve
+                Node veq_c;
+                Node val;
+                int ires = QuantArith::isolate( var, msum, veq_c, val, n.getKind() );
+                if( ires!=0 ){
+                  if( veq_c.isNull() ){
+                    r_add = val;
+                    varLhs = (ires==1);
+                    d_rel_dom_lit[hasPol][pol][n].d_rd[0] = getRDomain( q, var.getAttribute(InstVarNumAttribute()), false );
+                    d_rel_dom_lit[hasPol][pol][n].d_rd[1] = NULL;
+                  }
                 }
+              }else if( !hasNonVar ){
+                //merge the domains
+                d_rel_dom_lit[hasPol][pol][n].d_rd[0] = getRDomain( q, var.getAttribute(InstVarNumAttribute()), false );
+                d_rel_dom_lit[hasPol][pol][n].d_rd[1] = getRDomain( q, var2.getAttribute(InstVarNumAttribute()), false );
+                d_rel_dom_lit[hasPol][pol][n].d_merge = true;
               }
-            }else if( !hasNonVar ){
-              //merge the domains
-              d_rel_dom_lit[hasPol][pol][n].d_rd[0] = getRDomain( q, var.getAttribute(InstVarNumAttribute()), false );
-              d_rel_dom_lit[hasPol][pol][n].d_rd[1] = getRDomain( q, var2.getAttribute(InstVarNumAttribute()), false );
-              d_rel_dom_lit[hasPol][pol][n].d_merge = true;
             }
           }
         }