From: Nick Clifton <nickc@redhat.com>
Date: Thu, 28 May 2020 10:04:27 +0000 (+0100)
Subject: Fix a potential use of an uninitialised value in the ns32k disassembler.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=151f5de4a6548cd83a79b4705f1e901776ddacc5;p=binutils-gdb.git

Fix a potential use of an uninitialised value in the ns32k disassembler.

	* ns32k-dis.c (print_insn_ns32k): Change the arg_bufs array to
	static.
---

diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog
index 52cbe8e7ae5..01892090697 100644
--- a/opcodes/ChangeLog
+++ b/opcodes/ChangeLog
@@ -1,3 +1,8 @@
+2020-05-28  Nick Clifton  <nickc@redhat.com>
+
+	* ns32k-dis.c (print_insn_ns32k): Change the arg_bufs array to
+	static.
+
 2020-05-26  Sandra Loosemore  <sandra@codesourcery.com>
 
 	Fix extraction of signed constants in nios2 disassembler (again).
diff --git a/opcodes/ns32k-dis.c b/opcodes/ns32k-dis.c
index 12df182d0a4..ccad820d8f3 100644
--- a/opcodes/ns32k-dis.c
+++ b/opcodes/ns32k-dis.c
@@ -738,7 +738,10 @@ print_insn_ns32k (bfd_vma memaddr, disassemble_info *info)
   unsigned short first_word;
   int ioffset;		/* Bits into instruction.  */
   int aoffset;		/* Bits into arguments.  */
-  char arg_bufs[MAX_ARGS+1][ARG_LEN];
+  /* The arg_bufs array is made static in order to avoid a potential
+     use of an uninitialised value if we are asekd to disassemble a
+     corrupt instruction.  */
+  static char arg_bufs[MAX_ARGS+1][ARG_LEN];
   int argnum;
   int maxarg;
   struct private priv;