From: Tom de Vries <tdevries@suse.de>
Date: Wed, 19 May 2021 17:08:53 +0000 (+0200)
Subject: sim: ppc: fix some Wenum-compare warnings
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=17bb1d80f5f7a4e5894939d994972878ba95f5b7;p=binutils-gdb.git

sim: ppc: fix some Wenum-compare warnings

When compiling with --enable-werror and CFLAGS="-O0 -g -Wall", we run into:
...
src/sim/ppc/hw_phb.c: In function 'hw_phb_attach_address':
src/sim/ppc/hw_phb.c:315:12: error: comparison between \
  'attach_type {aka enum _attach_type}' and \
  'enum <anonymous>' [-Werror=enum-compare]
   if (type != hw_phb_normal_decode
            ^~
...

Fix this by casting type to hw_phb_decode.
---

diff --git a/sim/ppc/hw_phb.c b/sim/ppc/hw_phb.c
index 70d59d30844..a3c19264235 100644
--- a/sim/ppc/hw_phb.c
+++ b/sim/ppc/hw_phb.c
@@ -312,8 +312,8 @@ hw_phb_attach_address(device *me,
       || addr < pci_space->my_base)
     device_error(me, "attach addr (0x%lx) specified by %s outside of bus address range",
 		 (unsigned long)addr, device_path(client));
-  if (type != hw_phb_normal_decode
-      && type != hw_phb_subtractive_decode)
+  if ((hw_phb_decode)type != hw_phb_normal_decode
+      && (hw_phb_decode)type != hw_phb_subtractive_decode)
     device_error(me, "attach type (%d) specified by %s invalid",
 		 type, device_path(client));
   /* attach it to the relevent bus */