From: Timothy Arceri <tarceri@itsqueeze.com>
Date: Wed, 6 Jun 2018 23:49:37 +0000 (+1000)
Subject: radv: fix Coverity no effect control flow issue
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=186988e28f9fe31ad4d08626586d5167051a14e7;p=mesa.git

radv: fix Coverity no effect control flow issue

swizzle is unsigned so "desc->swizzle[c] < 0" is never true.
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
---

diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index 50ec904d514..958f2a2c821 100644
--- a/src/amd/vulkan/radv_formats.c
+++ b/src/amd/vulkan/radv_formats.c
@@ -921,7 +921,7 @@ bool radv_format_pack_clear_color(VkFormat format,
 	uint64_t clear_val = 0;
 
 	for (unsigned c = 0; c < 4; ++c) {
-		if (desc->swizzle[c] < 0 || desc->swizzle[c] >= 4)
+		if (desc->swizzle[c] >= 4)
 			continue;
 
 		const struct vk_format_channel_description *channel = &desc->channel[desc->swizzle[c]];