From: Eddie Hung <eddie@fpgeh.com>
Date: Thu, 14 May 2020 17:46:40 +0000 (-0700)
Subject: verilog: do not warn for attributes on null statements
X-Git-Tag: working-ls180~538^2~2
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=1c117ac0236517d0d7150dcc8d1fed19288bd692;p=yosys.git

verilog: do not warn for attributes on null statements
---

diff --git a/frontends/verilog/verilog_parser.y b/frontends/verilog/verilog_parser.y
index eb7e136ae..475557af9 100644
--- a/frontends/verilog/verilog_parser.y
+++ b/frontends/verilog/verilog_parser.y
@@ -2230,7 +2230,6 @@ behavioral_stmt:
 	non_opt_delay behavioral_stmt |
 	attr simple_behavioral_stmt ';' |
 	attr ';' {
-		log_file_warning(current_filename, get_line_num(), "Attribute(s) attached to null statement. Ignoring.\n");
 		free_attr($1);
 	} |
 	attr hierarchical_id {
@@ -2534,7 +2533,6 @@ module_gen_body:
 gen_stmt_or_module_body_stmt:
 	gen_stmt | module_body_stmt |
 	attr ';' {
-		log_file_warning(current_filename, get_line_num(), "Attribute(s) attached to null statement. Ignoring.\n");
 		free_attr($1);
 	};
 
diff --git a/tests/verilog/bug2037.ys b/tests/verilog/bug2037.ys
index 42c4b8f5d..eb4f0fac4 100644
--- a/tests/verilog/bug2037.ys
+++ b/tests/verilog/bug2037.ys
@@ -1,4 +1,3 @@
-logger -expect warning "Attribute\(s\) attached to null statement\. Ignoring\." 1
 logger -expect-no-warnings
 read_verilog <<EOT
 module test ();
@@ -7,10 +6,10 @@ module test ();
 		if (y) (* foo *) ;
 endmodule
 EOT
+select -assert-none a:* a:src %d
 
 
 design -reset
-logger -expect warning "Attribute\(s\) attached to null statement\. Ignoring\." 3 # cumulative
 logger -expect-no-warnings
 read_verilog <<EOT
 module test ();
@@ -19,10 +18,10 @@ module test ();
 		if (y) (* foo *) ; else (* bar *) ;
 endmodule
 EOT
+select -assert-none a:* a:src %d
 
 
 design -reset
-logger -expect warning "Attribute\(s\) attached to null statement\. Ignoring\." 4 # cumulative
 logger -expect-no-warnings
 read_verilog <<EOT
 module test ();
@@ -30,10 +29,10 @@ module test ();
     generate if (y) (* foo *) ; endgenerate
 endmodule
 EOT
+select -assert-none a:*
 
 
 design -reset
-logger -expect warning "Attribute\(s\) attached to null statement\. Ignoring\." 6 # cumulative
 logger -expect-no-warnings
 read_verilog <<EOT
 module test ();
@@ -41,3 +40,4 @@ module test ();
     generate if (y) (* foo *) ; else (* bar *); endgenerate
 endmodule
 EOT
+select -assert-none a:*