From: H.J. Lu <hjl.tools@gmail.com>
Date: Wed, 19 Jan 2005 16:15:11 +0000 (+0000)
Subject: 2005-01-19  H.J. Lu  <hongjiu.lu@intel.com>
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=1c16dfa5fdc5576b3129d29775da52302b72c500;p=binutils-gdb.git

2005-01-19  H.J. Lu  <hongjiu.lu@intel.com>

	PR 679
	* elflink.c (_bfd_elf_dynamic_symbol_p): Only protected
	non-function symbols are local.
	(_bfd_elf_symbol_refs_local_p): Likewise.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 97a61bdfdf7..e2abbe8a97f 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,10 @@
+2005-01-19  H.J. Lu  <hongjiu.lu@intel.com>
+
+	PR 679
+	* elflink.c (_bfd_elf_dynamic_symbol_p): Only protected
+	non-function symbols are local.
+	(_bfd_elf_symbol_refs_local_p): Likewise.
+
 2005-01-18  Alan Modra  <amodra@bigpond.net.au>
 
 	* bfd.c (bfd_link_just_syms): Add abfd param.
diff --git a/bfd/elflink.c b/bfd/elflink.c
index a973cd59a34..7a02d3415f0 100644
--- a/bfd/elflink.c
+++ b/bfd/elflink.c
@@ -2479,7 +2479,7 @@ _bfd_elf_dynamic_symbol_p (struct elf_link_hash_entry *h,
       /* Proper resolution for function pointer equality may require
 	 that these symbols perhaps be resolved dynamically, even though
 	 we should be resolving them to the current module.  */
-      if (!ignore_protected)
+      if (!ignore_protected || h->type != STT_FUNC)
 	binding_stays_local_p = TRUE;
       break;
 
@@ -2542,6 +2542,10 @@ _bfd_elf_symbol_refs_local_p (struct elf_link_hash_entry *h,
   if (ELF_ST_VISIBILITY (h->other) != STV_PROTECTED)
     return TRUE;
 
+  /* STV_PROTECTED non-function symbols are local.  */
+  if (h->type != STT_FUNC)
+    return TRUE;
+
   /* Function pointer equality tests may require that STV_PROTECTED
      symbols be treated as dynamic symbols, even when we know that the
      dynamic linker will resolve them locally.  */