From: Samuel Pitoiset Date: Wed, 22 Nov 2017 15:13:28 +0000 (+0100) Subject: Revert "radv: remove unnecessary memset() in radv_AllocateCommandBuffers()" X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=1cc00b8e0eb839096c1d6856df9213d6bad474ef;p=mesa.git Revert "radv: remove unnecessary memset() in radv_AllocateCommandBuffers()" This fixes two CTS regressions: - dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_primary - dEQP-VK.api.object_management.alloc_callback_fail_multiple.command_buffer_secondary These two tests are part the mustpass lists, so presumably they are correct and my change was wrong. This reverts commit 0f68208f1d1d3b7b2963dab40e84c60212518692. Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen --- diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 7d86eee9791..bd72ba2a878 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -2139,6 +2139,9 @@ VkResult radv_AllocateCommandBuffers( VkResult result = VK_SUCCESS; uint32_t i; + memset(pCommandBuffers, 0, + sizeof(*pCommandBuffers)*pAllocateInfo->commandBufferCount); + for (i = 0; i < pAllocateInfo->commandBufferCount; i++) { if (!list_empty(&pool->free_cmd_buffers)) {