From: Thomas Petazzoni Date: Tue, 29 Oct 2013 20:54:01 +0000 (+0100) Subject: toolchain-external: fix visibility and length of Linaro toolchain comment X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=1e0b97d166ad7414081231148e82c53cd2950cc5;p=buildroot.git toolchain-external: fix visibility and length of Linaro toolchain comment Maxime Ripard reported that the Linaro toolchains were not visible when selecting a Cortex-A, but forgetting to set the EABI to EABIhf. While this is expected, Buildroot should normally should a comment in this case. However, the comment is only visible when the selected ARM architecture is not ARMv7 *and* the EABI is not EABIhf. Instead, make the comment visible when either the selected architecture is not ARMv7 *or* when the selected EABI is not EABIhf. While we're at it, reword the comment text so that it actually fits within the limits of the menuconfig screen. Signed-off-by: Thomas Petazzoni Reported-by: Maxime Ripard Cc: Maxime Ripard --- diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in index 646f918be2..7f9b40adce 100644 --- a/toolchain/toolchain-external/Config.in +++ b/toolchain/toolchain-external/Config.in @@ -66,10 +66,9 @@ config BR2_TOOLCHAIN_EXTERNAL_LINARO_2013_07 To use this toolchain, you must disable soft float usage. -comment "Linaro toolchains available for Cortex-A{5,7,8,9,15} and the EABIhf ABI" +comment "Linaro toolchains available for Cortex-A + EABIhf" depends on BR2_arm - depends on BR2_GCC_TARGET_ARCH != "armv7-a" - depends on !BR2_ARM_EABIHF + depends on BR2_GCC_TARGET_ARCH != "armv7-a" || !BR2_ARM_EABIHF config BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201305 bool "Sourcery CodeBench ARM 2013.05"