From: Ian Romanick Date: Fri, 23 Dec 2011 18:59:38 +0000 (-0800) Subject: glsl: Don't mark assignment temporaries as read-only X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=1f125374e73d1718cd54c946826c76b09998c055;p=mesa.git glsl: Don't mark assignment temporaries as read-only The various l-value errors this was designed to catch are now caught by other means. Marking the temporaries as read-only now just prevents sensible error messages from being generated. It's 0:0(0): error: function parameter 'out p' references the read-only variable '_post_incdec_tmp' versus 0:13(5): error: function parameter 'out p' references a post-decrement operation Signed-off-by: Ian Romanick Reviewed-by: Paul Berry --- diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index cb2ef429f70..1aebca40fac 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -775,11 +775,6 @@ get_lvalue_copy(exec_list *instructions, ir_rvalue *lvalue) instructions->push_tail(new(ctx) ir_assignment(new(ctx) ir_dereference_variable(var), lvalue, NULL)); - /* Once we've created this temporary, mark it read only so it's no - * longer considered an lvalue. - */ - var->read_only = true; - return new(ctx) ir_dereference_variable(var); }