From: Mike Frysinger <vapier@gentoo.org>
Date: Sun, 3 Jan 2016 06:29:03 +0000 (-0500)
Subject: libiberty: dupargv: rewrite to use xstrdup
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=203217665139943a4f0d1797b9a5f913b3acf184;p=binutils-gdb.git

libiberty: dupargv: rewrite to use xstrdup

This func is basically open coding the xstrdup function, so gut it
and use it directly.
---

diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index aa598f277b2..ba1e0a51c33 100644
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,7 @@
+2016-01-05  Mike Frysinger  <vapier@gentoo.org>
+
+	* argv.c (dupargv): Replace strlen/xmalloc/strcpy with xstrdup.
+
 2015-12-28  Patrick Palka  <ppalka@gcc.gnu.org>
 
 	* crc32.c: In the documentation, don't refer to GDB's
diff --git a/libiberty/argv.c b/libiberty/argv.c
index f2727e8de95..5c3dd70b042 100644
--- a/libiberty/argv.c
+++ b/libiberty/argv.c
@@ -76,11 +76,7 @@ dupargv (char **argv)
 
   /* the strings */
   for (argc = 0; argv[argc] != NULL; argc++)
-    {
-      int len = strlen (argv[argc]);
-      copy[argc] = (char *) xmalloc (len + 1);
-      strcpy (copy[argc], argv[argc]);
-    }
+    copy[argc] = xstrdup (argv[argc]);
   copy[argc] = NULL;
   return copy;
 }