From: Timothy Arceri Date: Thu, 1 Mar 2018 04:37:25 +0000 (+1100) Subject: ac: pass the unmodified number of components to load gs inputs X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=20bd0f6a2bd631aec06d5bdbcf72fa562ec8a9a2;p=mesa.git ac: pass the unmodified number of components to load gs inputs Currently both users of this would overflow an array when the input was a dual slot double as they expected the number of components to be a max of 4. Since we pass the type we can just let the functions handle doubles in a way they choose. Reviewed-by: Dave Airlie --- diff --git a/src/amd/common/ac_nir_to_llvm.c b/src/amd/common/ac_nir_to_llvm.c index d2df2837c8a..1fe09de4848 100644 --- a/src/amd/common/ac_nir_to_llvm.c +++ b/src/amd/common/ac_nir_to_llvm.c @@ -3136,8 +3136,8 @@ static LLVMValueRef visit_load_var(struct ac_nir_context *ctx, return ctx->abi->load_inputs(ctx->abi, instr->variables[0]->var->data.location, instr->variables[0]->var->data.driver_location, - instr->variables[0]->var->data.location_frac, ve, - vertex_index, const_index, type); + instr->variables[0]->var->data.location_frac, + instr->num_components, vertex_index, const_index, type); } for (unsigned chan = comp; chan < ve + comp; chan++) {