From: Eric Anholt Date: Tue, 22 Nov 2011 02:03:30 +0000 (-0800) Subject: mesa: Make _mesa_is_stencil_format() consistent with _mesa_is_depth_format(). X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2134d2f35baadf4117e48aa3315608403622b79a;p=mesa.git mesa: Make _mesa_is_stencil_format() consistent with _mesa_is_depth_format(). There was only one consumer of this API, meta.c, which was intending to ask "is this format just stencil index (and nothing else)?". Instead, if one tried to glDrawPixels of GL_DEPTH_STENCIL-type formats, it would just try to draw the stencil parts. Nothing good came of this. This function looks rather silly at this point, but I'm leaving it in place to be the obvious parallel API to _mesa_is_depth_format(). Note that if you want the old behavior, you should use it as (_mesa_is_stencil_format() || _mesa_is_depthstencil_format()) like is commonly done for depth-related tests. Reviewed-by: Brian Paul Reviewed-by: Kenneth Graunke --- diff --git a/src/mesa/main/image.c b/src/mesa/main/image.c index 9b9e8380293..446d52e2559 100644 --- a/src/mesa/main/image.c +++ b/src/mesa/main/image.c @@ -853,7 +853,6 @@ _mesa_is_stencil_format(GLenum format) { switch (format) { case GL_STENCIL_INDEX: - case GL_DEPTH_STENCIL: return GL_TRUE; default: return GL_FALSE;