From: Brian Paul <brianp@vmware.com>
Date: Wed, 13 Jan 2010 00:08:07 +0000 (-0700)
Subject: llvmpipe: clamp maxx,maxy to framebuffer size (in terms of tiles)
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=214ffad01598c8780417b9fa9df75e951c8ac049;p=mesa.git

llvmpipe: clamp maxx,maxy to framebuffer size (in terms of tiles)

In some corner cases the right-most / bottom-most vertex can be
right on the edge of the framebuffer.  Because the maxx, maxy vals
are computed with a series of float/int, pixel/tile transformations
we can end up with maxx >= scene->x_tiles or maxy >= scene->y_tiles.
This leads to putting data into bins that never get processed, or
reset.  This becomes stale data that can lead to segfaults.

Clamping fixes this.
---

diff --git a/src/gallium/drivers/llvmpipe/lp_setup_tri.c b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
index 5197dca8f99..9248125de8b 100644
--- a/src/gallium/drivers/llvmpipe/lp_setup_tri.c
+++ b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
@@ -389,6 +389,11 @@ do_triangle_ccw(struct setup_context *setup,
    maxx = tri->maxx / TILE_SIZE;
    maxy = tri->maxy / TILE_SIZE;
 
+   /* Clamp maxx, maxy to framebuffer size
+    */
+   maxx = MIN2(maxx, scene->tiles_x - 1);
+   maxy = MIN2(maxy, scene->tiles_y - 1);
+
    /* Determine which tile(s) intersect the triangle's bounding box
     */
    if (miny == maxy && minx == maxx)