From: Corbin Simpson <MostAwesomeDude@gmail.com>
Date: Fri, 2 Apr 2010 21:21:50 +0000 (-0700)
Subject: r300g: Expound on dithering comment.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=21961f6e9614f234be704da93032cb4ec197eef4;p=mesa.git

r300g: Expound on dithering comment.
---

diff --git a/src/gallium/drivers/r300/r300_state.c b/src/gallium/drivers/r300/r300_state.c
index bf17d5d9203..2c0a7d82f5b 100644
--- a/src/gallium/drivers/r300/r300_state.c
+++ b/src/gallium/drivers/r300/r300_state.c
@@ -320,12 +320,17 @@ static void* r300_create_blend_state(struct pipe_context* pipe,
         }
     }
 
+    /* Neither fglrx nor classic r300 ever set this, regardless of dithering
+     * state. Since it's an optional implementation detail, we can leave it
+     * out and never dither.
+     *
+     * This could be revisited if we ever get quality or conformance hints.
+     *
     if (state->dither) {
-	/* fglrx appears to never set this */
-	blend->dither = 0;
-        /* blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT |
-                           R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT; */
+        blend->dither = R300_RB3D_DITHER_CTL_DITHER_MODE_LUT |
+                        R300_RB3D_DITHER_CTL_ALPHA_DITHER_MODE_LUT;
     }
+    */
 
     return (void*)blend;
 }