From: Samuel Martin <s.martin49@gmail.com>
Date: Wed, 22 Jan 2014 20:59:41 +0000 (+0100)
Subject: fs/common.mk: add host-mkpasswd if PACKAGES_USERS is not empty
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=22cdb652f51f08c52a87f66da49036eecdf68e8a;p=buildroot.git

fs/common.mk: add host-mkpasswd if PACKAGES_USERS is not empty

When using a custom rootfs skeleton, the host-mkpasswd target is not
automatically built, even if some packages add users (i.e. when
PACKAGES_USERS is not empty).

In this case, the rootfs generation may fail because the mkpasswd
provided by some distribution does not support all options used in the
mkusers script.

This patch avoids such trouble by automatically adding the host-mkpasswd
package to the dependency list of the rootfs targets if users needs
to be created.

[Peter: minor rewording of commit message]
Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---

diff --git a/fs/common.mk b/fs/common.mk
index aa9d961964..9f3262019b 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -37,7 +37,8 @@ USERS_TABLE = $(BUILD_DIR)/_users_table.txt
 define ROOTFS_TARGET_INTERNAL
 
 # extra deps
-ROOTFS_$(2)_DEPENDENCIES += host-fakeroot host-makedevs
+ROOTFS_$(2)_DEPENDENCIES += host-fakeroot host-makedevs \
+	$(if $(PACKAGES_USERS),host-mkpasswd)
 
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)_GZIP),y)
 ROOTFS_$(2)_COMPRESS_EXT = .gz