From: Brian Paul <brian.paul@tungstengraphics.com>
Date: Fri, 2 Jul 2004 16:39:59 +0000 (+0000)
Subject: document some assumptions made about compressed texture tile size
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2371033bbaf6e7477bfa893654a0467a084f335b;p=mesa.git

document some assumptions made about compressed texture tile size
---

diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
index d11b6e46094..b1f526c175d 100644
--- a/src/mesa/main/teximage.c
+++ b/src/mesa/main/teximage.c
@@ -2833,6 +2833,9 @@ compressed_texture_error_check(GLcontext *ctx, GLint dimensions,
 
 /**
  * Error checking for glCompressedTexSubImage[123]D().
+ * \warning  There are some bad assumptions here about the size of compressed
+ *           texture tiles (multiple of 4) used to test the validity of the
+ *           offset and size parameters.
  * \return error code or GL_NO_ERROR.
  */
 static GLenum
@@ -2890,6 +2893,9 @@ compressed_subtexture_error_check(GLcontext *ctx, GLint dimensions,
    if (level < 0 || level >= maxLevels)
       return GL_INVALID_VALUE;
 
+   /* XXX these tests are specific to the compressed format.
+    * this code should be generalized in some way.
+    */
    if ((xoffset & 3) != 0 || (yoffset & 3) != 0)
       return GL_INVALID_VALUE;