From: Janne Blomqvist Date: Fri, 4 Mar 2011 19:07:49 +0000 (+0200) Subject: PR 47802 Use builtins to check localtime_r return type X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=246a2730176b7ad6bc24e9397cf41ccda733f460;p=gcc.git PR 47802 Use builtins to check localtime_r return type From-SVN: r170683 --- diff --git a/libgfortran/ChangeLog b/libgfortran/ChangeLog index 73e2bb2ad13..33e2836ea7f 100644 --- a/libgfortran/ChangeLog +++ b/libgfortran/ChangeLog @@ -1,3 +1,9 @@ +2011-03-04 Janne Blomqvist + + PR libfortran/47802 + * intrinsics/ctime.c (strctime): Use builtins to check localtime_r + return type. + 2011-03-04 Janne Blomqvist PR libfortran/47802 diff --git a/libgfortran/intrinsics/ctime.c b/libgfortran/intrinsics/ctime.c index 29a0e6f00f2..92c0431357e 100644 --- a/libgfortran/intrinsics/ctime.c +++ b/libgfortran/intrinsics/ctime.c @@ -40,11 +40,16 @@ strctime (char *s, size_t max, const time_t *timep) { #ifdef HAVE_STRFTIME struct tm ltm; - /* Note: We can't use the return value of localtime_r, as some - targets provide localtime_r based on a draft of the POSIX + int failed; + /* Some targets provide a localtime_r based on a draft of the POSIX standard where the return type is int rather than the standardized struct tm*. */ - localtime_r (timep, <m); + __builtin_choose_expr (__builtin_classify_type (localtime_r (timep, <m)) + == 5, + failed = localtime_r (timep, <m) == NULL, + failed = localtime_r (timep, <m) != 0); + if (failed) + return 0; return strftime (s, max, "%c", <m); #else return 0;