From: Erico Nunes <nunes.erico@gmail.com>
Date: Mon, 29 Apr 2019 22:10:02 +0000 (+0200)
Subject: lima/gpir: add limit of max 512 instructions
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=257a9b0a94ddf2e88bc29771f1f46abdd2d4464d;p=mesa.git

lima/gpir: add limit of max 512 instructions

It has been noted that the lima GP has a limit of 512 instructions,
after which the shaders don't work and fail silently.
This commit adds a check to make the shader compilation abort when the
shader exceeds this limit, so that we get a clear reason for why the
program will not work.

Signed-off-by: Erico Nunes <nunes.erico@gmail.com>
Reviewed-by: Qiang Yu <yuq825@gmail.com>
---

diff --git a/src/gallium/drivers/lima/ir/gp/codegen.c b/src/gallium/drivers/lima/ir/gp/codegen.c
index 798cf8ec88e..1b7c8903c97 100644
--- a/src/gallium/drivers/lima/ir/gp/codegen.c
+++ b/src/gallium/drivers/lima/ir/gp/codegen.c
@@ -560,6 +560,12 @@ bool gpir_codegen_prog(gpir_compiler *comp)
       num_instr += list_length(&block->instr_list);
    }
 
+   if (num_instr > 512) {
+      gpir_error("shader too big (%d), GP has a 512 instruction limit.\n",
+                 num_instr);
+      return false;
+   }
+
    gpir_codegen_instr *code = rzalloc_array(comp->prog, gpir_codegen_instr, num_instr);
    if (!code)
       return false;