From: Pedro Alves <pedro@palves.net>
Date: Mon, 4 Jul 2022 15:43:06 +0000 (+0100)
Subject: Avoid duplicate QThreadEvents packets
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=26f047ce788b42b7b5f96515d119138a8ae43979;p=binutils-gdb.git

Avoid duplicate QThreadEvents packets

Similarly to QProgramSignals and QPassSignals, avoid sending duplicate
QThreadEvents packets.

Approved-By: Andrew Burgess <aburgess@redhat.com>
Change-Id: Iaf5babb0b64e1527ba4db31aac8674d82b17e8b4
---

diff --git a/gdb/remote.c b/gdb/remote.c
index 8c7979ce6a6..2a460f6f57a 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -529,6 +529,10 @@ public: /* data */
      the target know about program signals list changes.  */
   char *last_program_signals_packet = nullptr;
 
+  /* Similarly, the last QThreadEvents state we sent to the
+     target.  */
+  bool last_thread_events = false;
+
   gdb_signal last_sent_signal = GDB_SIGNAL_0;
 
   bool last_sent_step = false;
@@ -15010,6 +15014,9 @@ remote_target::thread_events (int enable)
   if (m_features.packet_support (PACKET_QThreadEvents) == PACKET_DISABLE)
     return;
 
+  if (rs->last_thread_events == enable)
+    return;
+
   xsnprintf (rs->buf.data (), size, "QThreadEvents:%x", enable ? 1 : 0);
   putpkt (rs->buf);
   getpkt (&rs->buf);
@@ -15019,6 +15026,7 @@ remote_target::thread_events (int enable)
     case PACKET_OK:
       if (strcmp (rs->buf.data (), "OK") != 0)
 	error (_("Remote refused setting thread events: %s"), rs->buf.data ());
+      rs->last_thread_events = enable;
       break;
     case PACKET_ERROR:
       warning (_("Remote failure reply: %s"), rs->buf.data ());