From: Roland Scheidegger <sroland@vmware.com>
Date: Tue, 30 Jan 2018 00:03:49 +0000 (+0100)
Subject: mesa: (trivial) add TODO comment for default results for internal queries
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=272e7e1bd5c12a3ef36027f0071065b7ce04e9e9;p=mesa.git

mesa: (trivial) add TODO comment for default results for internal queries
---

diff --git a/src/mesa/main/formatquery.c b/src/mesa/main/formatquery.c
index 9174fb6b276..1846fbc688c 100644
--- a/src/mesa/main/formatquery.c
+++ b/src/mesa/main/formatquery.c
@@ -700,6 +700,12 @@ _mesa_query_internal_format_default(struct gl_context *ctx, GLenum target,
    case GL_FRAMEBUFFER_RENDERABLE_LAYERED:
    case GL_FRAMEBUFFER_BLEND:
    case GL_FILTER:
+      /*
+       * TODO seems a tad optimistic just saying yes to everything here.
+       * Even for combinations which make no sense...
+       * And things like TESS_CONTROL_TEXTURE should definitely default to
+       * NONE if the driver doesn't even support tessellation...
+       */
       params[0] = GL_FULL_SUPPORT;
       break;
    case GL_NUM_TILING_TYPES_EXT: