From: Samuel Pitoiset Date: Tue, 16 Jul 2019 07:34:39 +0000 (+0200) Subject: radv/gfx10: support pixel shaders without exports X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=27d91062a8e89c62f5e8429b003e05a1585790c4;p=mesa.git radv/gfx10: support pixel shaders without exports Signed-off-by: Samuel Pitoiset Reviewed-by: Dave Airlie --- diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index fdb0ed29ea4..31495ec078d 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -4283,9 +4283,15 @@ radv_pipeline_init(struct radv_pipeline *pipeline, * stalls without this setting. * * Don't add this to CB_SHADER_MASK. + * + * GFX10 supports pixel shaders without exports by setting both the + * color and Z formats to SPI_SHADER_ZERO. The hw will skip export + * instructions if any are present. */ struct radv_shader_variant *ps = pipeline->shaders[MESA_SHADER_FRAGMENT]; - if (!blend.spi_shader_col_format) { + if ((pipeline->device->physical_device->rad_info.chip_class <= GFX9 || + ps->info.fs.can_discard) && + !blend.spi_shader_col_format) { if (!ps->info.info.ps.writes_z && !ps->info.info.ps.writes_stencil && !ps->info.info.ps.writes_sample_mask)