From: Kenneth Graunke <kenneth@whitecape.org>
Date: Sat, 4 Sep 2010 08:55:55 +0000 (-0700)
Subject: ir_reader: Emit global variables at the top of the instruction list.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2809d707231fba0e91abe1dd32e9f2d3284b9d3a;p=mesa.git

ir_reader: Emit global variables at the top of the instruction list.

Since functions are emitted when scanning for prototypes, functions
always come first, even if the original IR listed the variable
declarations first.

Fixes an ir_validate error (to be turned on in the next commit).
---

diff --git a/src/glsl/ir_reader.cpp b/src/glsl/ir_reader.cpp
index 1b081572725..408c20e88c9 100644
--- a/src/glsl/ir_reader.cpp
+++ b/src/glsl/ir_reader.cpp
@@ -337,8 +337,17 @@ read_instructions(_mesa_glsl_parse_state *st, exec_list *instructions,
    foreach_iter(exec_list_iterator, it, list->subexpressions) {
       s_expression *sub = (s_expression*) it.get();
       ir_instruction *ir = read_instruction(st, sub, loop_ctx);
-      if (ir != NULL)
-	 instructions->push_tail(ir);
+      if (ir != NULL) {
+	 /* Global variable declarations should be moved to the top, before
+	  * any functions that might use them.  Functions are added to the
+	  * instruction stream when scanning for prototypes, so without this
+	  * hack, they always appear before variable declarations.
+	  */
+	 if (st->current_function == NULL && ir->as_variable() != NULL)
+	    instructions->push_head(ir);
+	 else
+	    instructions->push_tail(ir);
+      }
    }
 }