From: Jakub Jelinek <jakub@redhat.com>
Date: Fri, 9 Mar 2018 22:23:14 +0000 (+0100)
Subject: re PR target/84772 (powerpc-spe: Spurious "is used uninitialized" warning, or possibl... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2956d3a8ddf9b1c676ab54b1a081a007f5081b8e;p=gcc.git

re PR target/84772 (powerpc-spe: Spurious "is used uninitialized" warning, or possibly incorrect codegen for va_arg(long double))

	PR target/84772
	* config/rs6000/rs6000.c (rs6000_gimplify_va_arg): Mark va_arg_tmp
	temporary TREE_ADDRESSABLE before gimplification of BUILT_IN_MEMCPY.
	* config/powerpcspe/powerpcspe.c (rs6000_gimplify_va_arg): Likewise.

	* gcc.dg/pr84772.c: New test.

From-SVN: r258399
---

diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index 7d7ece875a4..e0e8e982fa8 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,5 +1,10 @@
 2018-03-09  Jakub Jelinek  <jakub@redhat.com>
 
+	PR target/84772
+	* config/rs6000/rs6000.c (rs6000_gimplify_va_arg): Mark va_arg_tmp
+	temporary TREE_ADDRESSABLE before gimplification of BUILT_IN_MEMCPY.
+	* config/powerpcspe/powerpcspe.c (rs6000_gimplify_va_arg): Likewise.
+
 	PR c++/84767
 	* tree-inline.c (copy_tree_body_r): For INDIRECT_REF of a remapped
 	decl, use remap_type if we want to use the type.
diff --git a/gcc/config/powerpcspe/powerpcspe.c b/gcc/config/powerpcspe/powerpcspe.c
index fa8c8cc58f9..b500cd3b668 100644
--- a/gcc/config/powerpcspe/powerpcspe.c
+++ b/gcc/config/powerpcspe/powerpcspe.c
@@ -14254,6 +14254,7 @@ rs6000_gimplify_va_arg (tree valist, tree type, gimple_seq *pre_p,
 
       tree copy = build_call_expr (builtin_decl_implicit (BUILT_IN_MEMCPY),
 				   3, dest_addr, addr, size_int (rsize * 4));
+      TREE_ADDRESSABLE (tmp) = 1;
 
       gimplify_and_add (copy, pre_p);
       addr = dest_addr;
diff --git a/gcc/config/rs6000/rs6000.c b/gcc/config/rs6000/rs6000.c
index 63f62d47e8b..cdb1918d911 100644
--- a/gcc/config/rs6000/rs6000.c
+++ b/gcc/config/rs6000/rs6000.c
@@ -13537,6 +13537,7 @@ rs6000_gimplify_va_arg (tree valist, tree type, gimple_seq *pre_p,
 
       tree copy = build_call_expr (builtin_decl_implicit (BUILT_IN_MEMCPY),
 				   3, dest_addr, addr, size_int (rsize * 4));
+      TREE_ADDRESSABLE (tmp) = 1;
 
       gimplify_and_add (copy, pre_p);
       addr = dest_addr;
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index a8ef381211a..cac6560cf6a 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,5 +1,8 @@
 2018-03-09  Jakub Jelinek  <jakub@redhat.com>
 
+	PR target/84772
+	* gcc.dg/pr84772.c: New test.
+
 	PR c++/84076
 	* g++.dg/warn/Wformat-2.C: New test.
 
diff --git a/gcc/testsuite/gcc.dg/pr84772.c b/gcc/testsuite/gcc.dg/pr84772.c
new file mode 100644
index 00000000000..1241d212350
--- /dev/null
+++ b/gcc/testsuite/gcc.dg/pr84772.c
@@ -0,0 +1,13 @@
+/* PR target/84772 */
+/* { dg-do compile } */
+/* { dg-options "-O -Wuninitialized" } */
+
+#include <stdarg.h>
+
+void
+foo (int *x, int y, va_list ap)
+{
+  __builtin_memset (x, 0, sizeof (int));
+  for (int i = 0; i < y; i++)
+    va_arg (ap, long double);			/* { dg-bogus "uninitialized" } */  
+}