From: Ricardo Martincoski Date: Sat, 2 Dec 2017 04:28:24 +0000 (-0200) Subject: check-package: avoid false warning of useless flag X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=29d9f2f01445bb2e2f8a1cab293be4d62d34f2b0;p=buildroot.git check-package: avoid false warning of useless flag Just AUTORECONF = NO is redundant. Just HOST_AUTORECONF = NO is redundant. But the combination of AUTORECONF = YES + HOST_AUTORECONF = NO is valid. So basically for all variables that have inheritance between target and host, having the host variant of the variable set the variable value back to its default is correct if the target variable is set. Instead of increasing complexity of the script to fully detect this case, ignore the host flag set to its default value as it can be overriding a non-default value inherited from the equivalent target flag. Cc: Thomas Petazzoni Cc: Yann E. MORIN Reported-by: Yann E. MORIN Signed-off-by: Ricardo Martincoski Signed-off-by: Thomas Petazzoni --- diff --git a/utils/checkpackagelib/lib_mk.py b/utils/checkpackagelib/lib_mk.py index 6ed6011921..817e80923e 100644 --- a/utils/checkpackagelib/lib_mk.py +++ b/utils/checkpackagelib/lib_mk.py @@ -216,7 +216,7 @@ class UselessFlag(_CheckFunction): .format(self.filename, lineno, self.url_to_manual), text] - if self.DEFAULT_AUTOTOOLS_FLAG.search(text): + if self.DEFAULT_AUTOTOOLS_FLAG.search(text) and not text.lstrip().startswith("HOST_"): return ["{}:{}: useless default value " "({}#_infrastructure_for_autotools_based_packages)" .format(self.filename, lineno, self.url_to_manual),