From: Eric Engestrom <eric@engestrom.ch>
Date: Fri, 19 Jun 2020 10:44:41 +0000 (+0200)
Subject: bin/symbols-check: explain C++ symbols workaround
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2a61a8d95a8baebfbec53de8f6f2f70b09801486;p=mesa.git

bin/symbols-check: explain C++ symbols workaround

Signed-off-by: Eric Engestrom <eric@engestrom.ch>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5556>
---

diff --git a/bin/symbols-check.py b/bin/symbols-check.py
index 0d56a19561e..3b077371ad7 100644
--- a/bin/symbols-check.py
+++ b/bin/symbols-check.py
@@ -148,8 +148,10 @@ def main():
         if symbol in optional_symbols:
             continue
         if symbol[:2] == '_Z':
-            # Ignore random C++ symbols
-            #TODO: figure out if there's any way to avoid exporting them in the first place
+            # As ajax found out, the compiler intentionally exports symbols
+            # that we explicitely asked it not to export, and we can't do
+            # anything about it:
+            # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=36022#c4
             continue
         unknown_symbols.append(symbol)