From: Tamar Christina <tamar.christina@arm.com>
Date: Thu, 7 Jun 2018 10:53:13 +0000 (+0100)
Subject: Fix AArch64 unintialized variable which can cause diagnostic failures.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2a9b2c1abe29e1063240604d2464b8de9a46011f;p=binutils-gdb.git

Fix AArch64 unintialized variable which can cause diagnostic failures.

This patch fixes an uninitialized memory issue that can under certain
circumstances turn an error into a warning because non_fatal was not initialised
in all cases.

Verified using valgrind.

gas/config/tc-aarch64.c

	PR binutils/21446
	* tc-aarch64.c (record_operand_error, record_operand_error_with_data):
	  Initialize non_fatal.
---

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 0beb5b5f389..ac392b97547 100644
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,9 @@
+2018-06-08  Tamar Christina  <tamar.christina@arm.com>
+
+	PR binutils/21446
+	* tc-aarch64.c (record_operand_error, record_operand_error_with_data):
+	  Initialize non_fatal.
+
 2018-06-06  Sameera Deshpande  <sameera.deshpande@linaro.org>
 
 	* config/tc-aarch64.c (aarch64_cpus): Add support of ARMv8.4 in
diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c
index 1990cbebf9f..47ca0c8a1bc 100644
--- a/gas/config/tc-aarch64.c
+++ b/gas/config/tc-aarch64.c
@@ -4400,6 +4400,7 @@ record_operand_error (const aarch64_opcode *opcode, int idx,
   info.index = idx;
   info.kind = kind;
   info.error = error;
+  info.non_fatal = FALSE;
   record_operand_error_info (opcode, &info);
 }
 
@@ -4415,6 +4416,7 @@ record_operand_error_with_data (const aarch64_opcode *opcode, int idx,
   info.data[0] = extra_data[0];
   info.data[1] = extra_data[1];
   info.data[2] = extra_data[2];
+  info.non_fatal = FALSE;
   record_operand_error_info (opcode, &info);
 }