From: Brian Paul <brianp@vmware.com>
Date: Tue, 26 May 2015 17:30:22 +0000 (-0600)
Subject: docs: add information about reviewing patches
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2ab0ca36c155cc77e3d5c950270c70a24efee3d3;p=mesa.git

docs: add information about reviewing patches

Reviewed-by: Matt Turner <mattst88@gmail.com>
---

diff --git a/docs/devinfo.html b/docs/devinfo.html
index f5113b0bd72..eb3aba1364a 100644
--- a/docs/devinfo.html
+++ b/docs/devinfo.html
@@ -266,6 +266,31 @@ re-sending the whole series). Using --in-reply-to makes
 it harder for reviewers to accidentally review old patches.
 </p>
 
+<h3>Reviewing Patches</h3>
+
+<p>
+When you've reviewed a patch on the mailing list, please be unambiguous
+about your review.  That is, state either
+<pre>
+    Reviewed-by: Joe Hacker &lt;jhacker@foo.com&gt;
+</pre>
+or
+<pre>
+    Acked-by: Joe Hacker &lt;jhacker@foo.com&gt;
+</pre>
+Rather than saying just "LGTM" or "Seems OK".
+</p>
+
+<p>
+If small changes are suggested, it's OK to say something like:
+<pre>
+   With the above fixes, Reviewed-by: Joe Hacker &lt;jhacker@foo.com&gt;
+</pre>
+which tells the patch author that the patch can be committed, as long
+as the issues are resolved first.
+</p>
+
+
 <h3>Marking a commit as a candidate for a stable branch</h3>
 
 <p>