From: Gabe Black <gabeblack@google.com>
Date: Fri, 12 Oct 2018 11:53:00 +0000 (-0700)
Subject: mem: Expose the raw packet accessor functions.
X-Git-Tag: v19.0.0.0~1591
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2b979bd8913450355006fc9d9ccfa9dda21bbbb3;p=gem5.git

mem: Expose the raw packet accessor functions.

This avoids a place where data has its endianness switched so that when
the endianness based accessors switch it back it returns to normal. It
also makes it easier to show intent when accessing single bytes where
endianness doesn't matter, and there's no contextual endianness.

Change-Id: I1b97396c1b9bb39727d35112d90e3969e5fe0aab
Reviewed-on: https://gem5-review.googlesource.com/c/13455
Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Maintainer: Nikos Nikoleris <nikos.nikoleris@arm.com>
---

diff --git a/src/mem/packet.hh b/src/mem/packet.hh
index 0f45a7bae..515dcc701 100644
--- a/src/mem/packet.hh
+++ b/src/mem/packet.hh
@@ -1077,9 +1077,11 @@ class Packet : public Printable
     template <typename T>
     void set(T v, ByteOrder endian);
 
+#if THE_ISA != NULL_ISA
     /** Set the value in the data pointer to v as guest endian. */
     template <typename T>
     void set(T v);
+#endif
 
 
     /**
@@ -1173,7 +1175,6 @@ class Packet : public Printable
 
     /** @} */
 
-  private: // Private data accessor methods
     /** Get the data in the packet without byte swapping. */
     template <typename T>
     T getRaw() const;