From: Rob Clark <robclark@freedesktop.org>
Date: Thu, 1 Dec 2016 18:57:24 +0000 (-0800)
Subject: egl: un-fallthrough sync attr parsing
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2ba4c7e1548c6251085cd75563c182cc6708eaab;p=mesa.git

egl: un-fallthrough sync attr parsing

Doesn't work so well when you start having more than one possible
attrib.  Prep-work for next patch.

Signed-off-by: Rob Clark <robdclark@gmail.com>
Tested-by: Rafael Antognolli <rafael.antognolli@intel.com>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Tested-by: Chad Versace <chadversary@chromium.org>
---

diff --git a/src/egl/main/eglsync.c b/src/egl/main/eglsync.c
index 005cb31fc31..7b2c882d813 100644
--- a/src/egl/main/eglsync.c
+++ b/src/egl/main/eglsync.c
@@ -55,11 +55,11 @@ _eglParseSyncAttribList(_EGLSync *sync, const EGLAttrib *attrib_list)
       case EGL_CL_EVENT_HANDLE_KHR:
          if (sync->Type == EGL_SYNC_CL_EVENT_KHR) {
             sync->CLEvent = val;
-            break;
+         } else {
+            err = EGL_BAD_ATTRIBUTE;
          }
-         /* fall through */
+         break;
       default:
-         (void) val;
          err = EGL_BAD_ATTRIBUTE;
          break;
       }