From: Tom Tromey Date: Sun, 5 Jun 2022 17:12:57 +0000 (-0600) Subject: Fix warning-avoidance initialization in xcoffread.c X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2cbde639ae207987fa169ad5ed70e53c11ecdcba;p=binutils-gdb.git Fix warning-avoidance initialization in xcoffread.c With the registry rewrite series, on Fedora 34, I started seeing this error in xcoffread.c: ../../binutils-gdb/gdb/xcoffread.c: In function ‘void read_xcoff_symtab(objfile*, legacy_psymtab*)’: ../../binutils-gdb/gdb/xcoffread.c:948:25: error: ‘main_aux’ is used uninitialized [-Werror=uninitialized] 948 | union internal_auxent fcn_aux_saved = main_aux; | ^~~~~~~~~~~~~ ../../binutils-gdb/gdb/xcoffread.c:933:25: note: ‘main_aux’ declared here 933 | union internal_auxent main_aux; | ^~~~~~~~ I don't know why this error started suddenly... that seems weird, because it's not obviously related to the changes I made. Looking into it, it seems this line was intended to avoid a similar warning -- but since 'main_aux' is uninitialized at the point where it is used, this fix was incomplete. This patch avoids the warning by initializing using "{}". I'm checking this in. --- diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c index e520d7ad40b..9e571d0419c 100644 --- a/gdb/xcoffread.c +++ b/gdb/xcoffread.c @@ -945,7 +945,7 @@ read_xcoff_symtab (struct objfile *objfile, legacy_psymtab *pst) struct xcoff_symbol fcn_stab_saved = { 0 }; /* fcn_cs_saved is global because process_xcoff_symbol needs it. */ - union internal_auxent fcn_aux_saved = main_aux; + union internal_auxent fcn_aux_saved {}; struct context_stack *newobj; const char *filestring = pst->filename; /* Name of the current file. */