From: Alan Modra <amodra@gmail.com>
Date: Thu, 23 Aug 2018 14:50:05 +0000 (+0930)
Subject: PR23566, false uninitialized warning
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2cd65cb935bcf1511c7e7bb77ce7bd46234300db;p=binutils-gdb.git

PR23566, false uninitialized warning

	PR 23566
	* emultempl/elf32.em (before_allocation): Warning fix.
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 66f890cbd0c..4b33f72eff5 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-23  Alan Modra  <amodra@gmail.com>
+
+	PR 23566
+	* emultempl/elf32.em (before_allocation): Warning fix.
+
 2018-08-23  H.J. Lu  <hongjiu.lu@intel.com>
 
 	PR ld/23536
diff --git a/ld/emultempl/elf32.em b/ld/emultempl/elf32.em
index 5160e2449b9..eac4ba795e9 100644
--- a/ld/emultempl/elf32.em
+++ b/ld/emultempl/elf32.em
@@ -1680,11 +1680,6 @@ gld${EMULATION_NAME}_append_to_separated_string (char **to, char *op_arg)
     }
 }
 
-#if defined(__GNUC__) && GCC_VERSION < 4006
-  /* Work around a GCC uninitialized warning bug fixed in GCC 4.6.  */
-static struct bfd_link_hash_entry ehdr_start_empty;
-#endif
-
 /* This is called after the sections have been attached to output
    sections, but before any sizes or addresses have been set.  */
 
@@ -1695,13 +1690,11 @@ gld${EMULATION_NAME}_before_allocation (void)
   asection *sinterp;
   bfd *abfd;
   struct elf_link_hash_entry *ehdr_start = NULL;
-#if defined(__GNUC__) && GCC_VERSION < 4006
-  /* Work around a GCC uninitialized warning bug fixed in GCC 4.6.  */
-  struct bfd_link_hash_entry ehdr_start_save = ehdr_start_empty;
-#else
   struct bfd_link_hash_entry ehdr_start_save;
-#endif
 
+  /* The memset is here only to silence brain-dead compiler warnings
+     that the variable may be used uninitialized.  */
+  memset (&ehdr_start_save, 0, sizeof ehdr_start_save);
   if (is_elf_hash_table (link_info.hash))
     {
       _bfd_elf_tls_setup (link_info.output_bfd, &link_info);