From: Alan Modra <amodra@gmail.com>
Date: Wed, 26 Aug 2020 10:32:07 +0000 (+0930)
Subject: PR26498 UBSAN: elf32-spu.c:2292 left shift overflow
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2d0ce6779c25fb28b3b35cee02871b9a8d4cd29b;p=binutils-gdb.git

PR26498 UBSAN: elf32-spu.c:2292 left shift overflow

	PR 26498
	* elf32-spu.c (find_function_stack_adjust): Use unsigned vars to
	avoid UB left shift.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index cbce5be495a..1cd7943abc3 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,9 @@
+2020-08-26  Alan Modra  <amodra@gmail.com>
+
+	PR 26498
+	* elf32-spu.c (find_function_stack_adjust): Use unsigned vars to
+	avoid UB left shift.
+
 2020-08-26  Alan Modra  <amodra@gmail.com>
 
 	PR 26484
diff --git a/bfd/elf32-spu.c b/bfd/elf32-spu.c
index 13cff2c5e09..167b90d6a2f 100644
--- a/bfd/elf32-spu.c
+++ b/bfd/elf32-spu.c
@@ -2209,14 +2209,14 @@ find_function_stack_adjust (asection *sec,
 			    bfd_vma *lr_store,
 			    bfd_vma *sp_adjust)
 {
-  int reg[128];
+  int32_t reg[128];
 
   memset (reg, 0, sizeof (reg));
   for ( ; offset + 4 <= sec->size; offset += 4)
     {
       unsigned char buf[4];
       int rt, ra;
-      int imm;
+      uint32_t imm;
 
       /* Assume no relocs on stack adjusing insns.  */
       if (!bfd_get_section_contents (sec->owner, sec, buf, offset, 4))