From: Ijaz, Abdul B Date: Fri, 8 Sep 2023 20:56:18 +0000 (+0200) Subject: testsuite, fortran: Fix regression due to fix for ifort's 'start' behavior X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2e2d1ccdc5b66fcb765c7efd2b6ba58c9932697e;p=binutils-gdb.git testsuite, fortran: Fix regression due to fix for ifort's 'start' behavior Got a regression email due to merge of commit in CI config tcwg_gdb_check/master-aarch64 : https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=41439185cd0075bbb1aedf9665685dba0827cfec Begining of test "gdb.fortran/array-slices-bad.exp" was updated in above commit to start the test from running to line with tag "First Breakpoint" instead of "fortran_runto_main". Reason of the regression is shared libraries are still loaded after hitting the breakpoint as "nosharedlibrary" is already called before hitting the breakpoint. So now after this change test is updated accordingly to disable and unload shared libraries symbols after hitting the first breakpoint. Approved-By: Andrew Burgess --- diff --git a/gdb/testsuite/gdb.fortran/array-slices-bad.exp b/gdb/testsuite/gdb.fortran/array-slices-bad.exp index d7b00694539..280628db1b4 100644 --- a/gdb/testsuite/gdb.fortran/array-slices-bad.exp +++ b/gdb/testsuite/gdb.fortran/array-slices-bad.exp @@ -25,17 +25,17 @@ if {[prepare_for_testing ${testfile}.exp ${testfile} ${srcfile} \ return -1 } +if {![runto [gdb_get_line_number "First Breakpoint"]]} { + perror "couldn't run to breakpoint First Breakpoint" + return -1 +} + # Avoid shared lib symbols. gdb_test_no_output "set auto-solib-add off" # Avoid libc symbols, in particular the 'array' type. gdb_test_no_output "nosharedlibrary" -if {![runto [gdb_get_line_number "First Breakpoint"]]} { - perror "couldn't run to breakpoint First Breakpoint" - return -1 -} - gdb_breakpoint [gdb_get_line_number "Second Breakpoint"] gdb_breakpoint [gdb_get_line_number "Final Breakpoint"]