From: Nick Clifton <nickc@redhat.com>
Date: Thu, 12 Aug 2010 13:11:11 +0000 (+0000)
Subject:         PR binutils/11742
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2e49a6d0109e0e3f88aac9202b5331fe251c7b01;p=binutils-gdb.git

    PR binutils/11742
        * readelf.c (get_archive_member_name): Do not read beyond the end
        of the ar_name field.
---

diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index e86b293ac03..d051895754b 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,9 @@
+2010-08-12  Michael Haubenwallner  <haubi@gentoo.org>
+
+	PR binutils/11742
+	* readelf.c (get_archive_member_name): Do not read beyond the end
+	of the ar_name field.
+
 2010-08-03  Tristan Gingold  <gingold@adacore.com>
 
 	* dwarf.c (display_debug_lines): Mark file argument unused.
diff --git a/binutils/readelf.c b/binutils/readelf.c
index 614f761e94e..30a7fcc4a11 100644
--- a/binutils/readelf.c
+++ b/binutils/readelf.c
@@ -12556,7 +12556,8 @@ get_archive_member_name (struct archive_info *  arch,
 
   /* We have a normal (short) name.  */
   j = 0;
-  while ((arch->arhdr.ar_name[j] != '/') && (j < 16))
+  while ((arch->arhdr.ar_name[j] != '/')
+	 && (j < sizeof (arch->arhdr.ar_name) - 1))
     j++;
   arch->arhdr.ar_name[j] = '\0';
   return arch->arhdr.ar_name;