From: Simon Marchi Date: Tue, 10 Oct 2017 19:10:25 +0000 (-0400) Subject: get_integer_valueof: Don't output value in test name X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=2f20e312aad6;p=binutils-gdb.git get_integer_valueof: Don't output value in test name The get_integer_valueof outputs the value it has read as part of the test name. This causes test names to vary from run to run, and adds some noise when diffing test results. e.g.: -PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (28770) +PASS: gdb.threads/process-dies-while-detaching.exp: multi-process: continue: killed outside: get integer valueof "mypid" (32238) This patch removes that, since it's probably not very useful. gdb/testsuite/ChangeLog: * lib/gdb.exp (get_integer_valueof): Don't output read value in test name. --- diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 4ad0c02992a..dd0645c80fc 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2017-10-10 Simon Marchi + + * lib/gdb.exp (get_integer_valueof): Don't output read value in test name. + 2017-10-10 Pedro Alves * gdb.mi/mi-pthreads.exp (check_mi_thread_command_set): Don't diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 48fec2f56b9..9d8296a109e 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -5634,7 +5634,7 @@ proc get_integer_valueof { exp default {test ""} } { gdb_test_multiple "print /d ${exp}" "$test" { -re "\\$\[0-9\]* = (\[-\]*\[0-9\]*).*$gdb_prompt $" { set val $expect_out(1,string) - pass "$test ($val)" + pass "$test" } timeout { fail "$test (timeout)"