From: Kenneth Graunke <kenneth@whitecape.org>
Date: Mon, 31 Dec 2018 17:19:07 +0000 (-0800)
Subject: iris: Leave a comment about why Broadwell images are broken
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=307f3f9924791ab0f1b830e4739bc10c28025e5a;p=mesa.git

iris: Leave a comment about why Broadwell images are broken

There are a variety of ways to fix this, many of which are simple, but
I could use some advice on which ones other people prefer, and so we'll
punt until after the holidays.
---

diff --git a/src/gallium/drivers/iris/iris_program.c b/src/gallium/drivers/iris/iris_program.c
index 47a4b635f99..499af26da9d 100644
--- a/src/gallium/drivers/iris/iris_program.c
+++ b/src/gallium/drivers/iris/iris_program.c
@@ -668,6 +668,10 @@ iris_setup_uniforms(const struct brw_compiler *compiler,
             nir_deref_instr *deref = nir_src_as_deref(intrin->src[0]);
             nir_variable *var = nir_deref_instr_get_variable(deref);
 
+            /* XXX: var->data.binding is not set properly.  We need to run
+             * some form of gl_nir_lower_samplers_as_deref() to get it.
+             * This breaks tests which use more than one image.
+             */
             if (img_idx[var->data.binding] == -1) {
                /* GL only allows arrays of arrays of images. */
                assert(glsl_type_is_image(glsl_without_array(var->type)));