From: Pedro Alves Date: Thu, 18 Jun 2020 20:28:34 +0000 (+0100) Subject: Don't write to inferior_ptid in windows-nat.c, part I X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=31ce04e9e0ce96e752e2c53dfad5881d24e9f080;p=binutils-gdb.git Don't write to inferior_ptid in windows-nat.c, part I The inferior_ptid hack in do_initial_win32_stuff, added back in 2008: https://sourceware.org/ml/gdb-patches/2008-10/msg00012.html with: commit 9f9d052e600ed9436f9fd558d62a189c8cc3d43e Author: Pierre Muller AuthorDate: Thu Oct 2 14:20:07 2008 +0000 * win32-nat.c (do_initial_win32_stuff): Set inferior_ptid. is no longer needed. Back then, current_inferior looked like this: struct inferior* current_inferior (void) { struct inferior *inf = find_inferior_pid (ptid_get_pid (inferior_ptid)); gdb_assert (inf); return inf; } Nowadays, current_inferior() just returns the global current_inferior_ pointer, which didn't exist back then. gdb/ChangeLog: 2020-06-18 Pedro Alves * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index bc8c37144f3..18da2d92b00 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-06-18 Pedro Alves + + * windows-nat.c (do_initial_windows_stuff): No longer set inferior_ptid. + 2020-06-18 Pedro Alves * go32-nat.c (go32_nat_target::create_inferior): Switch to thread diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c index c3a4bdc0d47..19bc52bbbb6 100644 --- a/gdb/windows-nat.c +++ b/gdb/windows-nat.c @@ -2019,12 +2019,6 @@ do_initial_windows_stuff (struct target_ops *ops, DWORD pid, int attaching) inferior_appeared (inf, pid); inf->attach_flag = attaching; - /* Make the new process the current inferior, so terminal handling - can rely on it. When attaching, we don't know about any thread - id here, but that's OK --- nothing should be referencing the - current thread until we report an event out of windows_wait. */ - inferior_ptid = ptid_t (pid); - target_terminal::init (); target_terminal::inferior ();