From: Tapani Pälli <tapani.palli@intel.com>
Date: Fri, 17 Jan 2020 08:30:03 +0000 (+0200)
Subject: isl/gen12: add reminder comment about missing WA with 3D surfaces
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=31feae1c21998032491c9fe6539e5f339b275e64;p=mesa.git

isl/gen12: add reminder comment about missing WA with 3D surfaces

Signed-off-by: Tapani Pälli <tapani.palli@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3441>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/3441>
---

diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 54feaec6212..2e26bb02168 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -1980,6 +1980,19 @@ isl_surf_get_ccs_surf(const struct isl_device *dev,
       return false;
    }
 
+   /* GEN:BUG:1207137018
+    *
+    * TODO: implement following workaround currently covered by the restriction
+    * above. If following conditions are met:
+    *
+    *    - RENDER_SURFACE_STATE.Surface Type == 3D
+    *    - RENDER_SURFACE_STATE.Auxiliary Surface Mode != AUX_NONE
+    *    - RENDER_SURFACE_STATE.Tiled ResourceMode is TYF or TYS
+    *
+    * Set the value of RENDER_SURFACE_STATE.Mip Tail Start LOD to a mip that
+    * larger than those present in the surface (i.e. 15)
+    */
+
    /* TODO: More conditions where it can fail. */
 
    /* From the Ivy Bridge PRM, Vol2 Part1 11.7 "MCS Buffer for Render