From: Marek Olšák <maraeo@gmail.com>
Date: Wed, 25 Jan 2012 13:08:16 +0000 (+0100)
Subject: scons: don't add -Wmissing-field-initializers
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=335d49ef1581c2954cfa17a5c603ca54dd770a89;p=mesa.git

scons: don't add -Wmissing-field-initializers

The warning is absolutely useless. It doesn't actually say that there are
uninitialized variables. It points out the fact that there are missing
initializers and that variables are initialized to zero implicitly, which is
exactly what we want and what we commonly make use of.

C90 and C99 require all unspecified variables in the initializer list to be set
to zero.
---

diff --git a/scons/gallium.py b/scons/gallium.py
index 86adc3e6a26..eed89cf71ca 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -364,10 +364,6 @@ def generate(env):
             '-Wmissing-prototypes',
             '-std=gnu99',
         ]
-        if distutils.version.LooseVersion(ccversion) >= distutils.version.LooseVersion('4.0'):
-            ccflags += [
-                '-Wmissing-field-initializers',
-            ]
         if distutils.version.LooseVersion(ccversion) >= distutils.version.LooseVersion('4.2'):
             ccflags += [
                 '-Wpointer-arith',