From: Brian Paul Date: Sat, 1 Feb 2014 17:51:43 +0000 (-0700) Subject: mesa: change GL_ALL_ATTRIB_BITS to 0xFFFFFFFF X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=349b76a55364c0bb33daa4e1ebe36dd689e35807;p=mesa.git mesa: change GL_ALL_ATTRIB_BITS to 0xFFFFFFFF This has been wrong for many years. It was originally 0x000FFFFF and long ago there was discussion about whether GL_ALL_ATTRIB_BITS should include the then-new GL_MULTISAMPLE_BIT bit. Eventually the ARB decided that glPushAttrib(GL_ALL_ATTRIB_BITS) should save all current and future attribute groups (hence ~0). Unfortunately, Mesa's gl.h was never updated. This was just recently spotted by Eric Anholt and reported as a bug to the ARB. Ian, Jon Leech and I discussed it at the ARB meeting and decided to change Mesa's value to reflect the ARB's decision. Acked-by: Eric Anholt --- diff --git a/include/GL/gl.h b/include/GL/gl.h index 48343f65d93..4e2932df7df 100644 --- a/include/GL/gl.h +++ b/include/GL/gl.h @@ -694,7 +694,7 @@ typedef double GLclampd; /* double precision float in [0,1] */ #define GL_LIST_BIT 0x00020000 #define GL_TEXTURE_BIT 0x00040000 #define GL_SCISSOR_BIT 0x00080000 -#define GL_ALL_ATTRIB_BITS 0x000FFFFF +#define GL_ALL_ATTRIB_BITS 0xFFFFFFFF /* OpenGL 1.1 */