From: Thomas Petazzoni Date: Tue, 9 Aug 2016 10:25:11 +0000 (+0200) Subject: size-stats: fix bug when parsing file names with comma X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=34b1bdeba40bf303dc8821421745d5b38a729984;p=buildroot.git size-stats: fix bug when parsing file names with comma The size-stats script fails when the usb_modeswitch_data is enabled, because this package installs files that contain commas in their name. However, the size-stats script also uses comma as a separator for its CSV files, causing a "ValueError: too many values to unpack" in: pkg, fpath = l.split(",") Fix this by splitting only the two fields that need to be split. The bug was reported by Matthias , who also suggested a fix. Fixes bug #9136. Reported-by: Matthias Signed-off-by: Thomas Petazzoni --- diff --git a/support/scripts/size-stats b/support/scripts/size-stats index 81d96caa12..0ddcc07902 100755 --- a/support/scripts/size-stats +++ b/support/scripts/size-stats @@ -66,7 +66,7 @@ def build_package_dict(builddir): filesdict = {} with open(os.path.join(builddir, "build", "packages-file-list.txt")) as filelistf: for l in filelistf.readlines(): - pkg, fpath = l.split(",") + pkg, fpath = l.split(",", 1) # remove the initial './' in each file path fpath = fpath.strip()[2:] fullpath = os.path.join(builddir, "target", fpath)