From: Alan Modra Date: Fri, 13 Oct 2017 04:53:35 +0000 (+1030) Subject: PR22263 testcase X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=354bac403e9a19bbbfb676d854db5f11f0e84c27;p=binutils-gdb.git PR22263 testcase A number of targets need dynamic relocs in PIEs for reasons other than relocating thread variables. The PR is about text relocations, and, reading between the lines, unnecessary dynamic tprel relocations. Change the test to check for those conditions rather than no dynamic relocations PR ld/22263 * testsuite/ld-elf/tls.exp: Link with -z text. * testsuite/ld-elf/pr22263-1.rd: Test for tprel relocs. --- diff --git a/ld/ChangeLog b/ld/ChangeLog index b0f7cd22569..47cc5a89b06 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,9 @@ +2017-10-13 Alan Modra + + PR ld/22263 + * testsuite/ld-elf/tls.exp: Link with -z text. + * testsuite/ld-elf/pr22263-1.rd: Test for tprel relocs. + 2017-10-12 H.J. Lu PR ld/22263 diff --git a/ld/testsuite/ld-elf/pr22263-1.rd b/ld/testsuite/ld-elf/pr22263-1.rd index 9a583fbfad4..f29f7fefd9e 100644 --- a/ld/testsuite/ld-elf/pr22263-1.rd +++ b/ld/testsuite/ld-elf/pr22263-1.rd @@ -1,2 +1,5 @@ - -There are no relocations in this file. +# tprel relocs are not needed in a PIE +#failif +#... +.* R_.*_TP.* +#pass diff --git a/ld/testsuite/ld-elf/tls.exp b/ld/testsuite/ld-elf/tls.exp index 9d64d6c19f4..dd240712627 100644 --- a/ld/testsuite/ld-elf/tls.exp +++ b/ld/testsuite/ld-elf/tls.exp @@ -40,7 +40,7 @@ if { [which $CC] == 0 } { run_ld_link_tests [list \ [list \ "Build pr22263-1" \ - "-pie -e _start" \ + "-pie -e _start -z text" \ "" \ "" \ { pr22263-1a.c pr22263-1b.c } \