From: Joel Brobecker <brobecker@adacore.com>
Date: Mon, 6 Oct 2014 18:50:46 +0000 (-0400)
Subject: common-defs.h: include <stdarg.h> before <stdio.h>
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=355e210214ba52d477f25b33de00dbbcfb566c70;p=binutils-gdb.git

common-defs.h: include <stdarg.h> before <stdio.h>

When trying to build gdbserver on ppc-lynx178, the compiler reports
while trying to compile gdbserver/ax.c that vsprintf is not declared.
Looking at my C99 reference manual (a draft), I see the following
synopsis:

    #include <stdarg.h>
    #include <stdio.h>
    int vsprintf(char * restrict s, [etc]);

Looking at stdio.h on LynxOS-178, if found where vsprintf gets
declared:

    #if defined(__varargs_h) || defined(__stdarg_h) \
            || defined(_VARARGS_H) || defined(_STDARG_H)
    extern int vsprintf             _AP((char *, const char *, va_list));
    #endif

Digging further, I noticed that common-defs.h, which is included
via server.h, includes stdarg.h after including stdio, explaining
why vsprintf does not get declared in this case.

This patch fixes the problem by including stdarg.h before stdio.h.

gdb/ChangeLog:

        * common/common-defs.h: Move <stdarg.h> #include ahead of
        <stdio.h> #include.

Tested on x86_64-linux.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index bfc427f387c..0ba42399c18 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2014-11-14  Joel Brobecker  <brobecker@adacore.com>
+
+	* common/common-defs.h: Move <stdarg.h> #include ahead of
+	<stdio.h> #include.
+
 2014-11-14  Pedro Alves  <palves@redhat.com>
 
 	* charset.c [PHONY_ICONV && !EILSEQ] (EILSEQ): Don't define.
diff --git a/gdb/common/common-defs.h b/gdb/common/common-defs.h
index 29c8ab3039c..4d2e8a73bb6 100644
--- a/gdb/common/common-defs.h
+++ b/gdb/common/common-defs.h
@@ -27,9 +27,9 @@
 #include "build-gnulib/config.h"
 #endif
 
+#include <stdarg.h>
 #include <stdio.h>
 #include <stdlib.h>
-#include <stdarg.h>
 #include <stddef.h>
 #include <string.h>
 #include <errno.h>