From: Luca Ceresoli Date: Tue, 14 May 2013 02:46:03 +0000 (+0000) Subject: legal-info: fail trying to copy a non-existent license file X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=376c3aad61dbeb8e2126e13658fd150b70746afb;p=buildroot.git legal-info: fail trying to copy a non-existent license file If a package's _LICENSE_FILES contains the name of a non-existent file, the make process would continue and return true, unless the non-existent file is the last listed. Fix this wrong beaviour by failing with an error when any of the listed files is missing. Reported-by: Thomas Petazzoni Signed-off-by: Luca Ceresoli Signed-off-by: Peter Korsgaard --- diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index b55b5f0b48..56fca6be85 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -508,9 +508,7 @@ ifeq ($(call qstrip,$$($(2)_LICENSE_FILES)),) @$(call legal-license-nofiles,$$($(2)_RAWNAME)) @$(call legal-warning-pkg,$$($(2)_RAWNAME),cannot save license ($(2)_LICENSE_FILES not defined)) else - @for F in $$($(2)_LICENSE_FILES); do \ - $(call legal-license-file,$$($(2)_RAWNAME),$$$${F},$$($(2)_DIR)/$$$${F}); \ - done + @$(foreach F,$($(2)_LICENSE_FILES),$(call legal-license-file,$$($(2)_RAWNAME),$(F),$$($(2)_DIR)/$(F))$$(sep)) endif ifeq ($$($(2)_REDISTRIBUTE),YES) # Copy the source tarball (just hardlink if possible)