From: Alan Modra <amodra@gmail.com>
Date: Mon, 30 Dec 2019 10:47:08 +0000 (+1030)
Subject: coff object_p memory leaks
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=37d5ab199b072e3cf1e8bf2a9262767c4737d256;p=binutils-gdb.git

coff object_p memory leaks

	* coffgen.c (coff_real_object_p): Free malloc'd memory on failure.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 186346e9c15..809f1ba56d4 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,7 @@
+2019-12-30  Alan Modra  <amodra@gmail.com>
+
+	* coffgen.c (coff_real_object_p): Free malloc'd memory on failure.
+
 2019-12-30  Alan Modra  <amodra@gmail.com>
 
 	* archive.c (do_slurp_bsd_armap): Use bfd_alloc rather than
diff --git a/bfd/coffgen.c b/bfd/coffgen.c
index 57a18b02dc1..34d8d50506a 100644
--- a/bfd/coffgen.c
+++ b/bfd/coffgen.c
@@ -305,6 +305,9 @@ coff_real_object_p (bfd *abfd,
   return abfd->xvec;
 
  fail:
+  obj_coff_keep_syms (abfd) = FALSE;
+  obj_coff_keep_strings (abfd) = FALSE;
+  _bfd_coff_free_symbols (abfd);
   bfd_release (abfd, tdata);
  fail2:
   abfd->tdata.any = tdata_save;