From: Romain Naour Date: Sat, 22 Feb 2020 18:10:40 +0000 (+0100) Subject: package/jpeg-turbo: force fPIC for shared libraries X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=37f3d09d46a7b3b4ba8f564c0005f4ab7ff1a69c;p=buildroot.git package/jpeg-turbo: force fPIC for shared libraries When BR2_SSP_ALL is set, there is a link issue due to missing -fPIC in CFLAGS. Set CMAKE_POSITION_INDEPENDENT_CODE=ON to add it. This is a similar fix as for gtest package [1] [1] https://git.buildroot.net/buildroot/commit/?id=2026621f3c60167aa8ba48e658be1b214d1347d7 Fixes: http://autobuild.buildroot.net/results/e1f/e1f164cee16b037c0232fdda40fc16caf8f0c0af Signed-off-by: Romain Naour Cc: Murat Demirten Signed-off-by: Yann E. MORIN --- diff --git a/package/jpeg-turbo/jpeg-turbo.mk b/package/jpeg-turbo/jpeg-turbo.mk index 2767ce6de4..126b470630 100644 --- a/package/jpeg-turbo/jpeg-turbo.mk +++ b/package/jpeg-turbo/jpeg-turbo.mk @@ -31,6 +31,16 @@ else JPEG_TURBO_CONF_OPTS += -DWITH_SIMD=OFF endif +# Ensure that jpeg-turbo is compiled with -fPIC to allow linking the static +# libraries with dynamically linked programs. This is not a requirement +# for most architectures but is mandatory for ARM. +# This allow to avoid link issues with BR2_SSP_ALL: +# jsimd_none.c.o: relocation R_AARCH64_ADR_PREL_PG_HI21 against external symbol `__stack_chk_guard@@GLIBC_2.17' +# can not be used when making a shared object; recompile with -fPIC +ifeq ($(BR2_STATIC_LIBS),) +JPEG_TURBO_CONF_OPTS += -DCMAKE_POSITION_INDEPENDENT_CODE=ON +endif + define JPEG_TURBO_REMOVE_USELESS_TOOLS rm -f $(addprefix $(TARGET_DIR)/usr/bin/,cjpeg djpeg jpegtran rdjpgcom tjbench wrjpgcom) endef