From: Ian Romanick Date: Mon, 26 Feb 2018 22:49:47 +0000 (-0800) Subject: nir: Mark bcsel-to-fmin (or fmax) transformations as inexact X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=380136e998f8d89380adba7d071249d6469339db;p=mesa.git nir: Mark bcsel-to-fmin (or fmax) transformations as inexact These transformations are inexact because section 4.7.1 (Range and Precision) says: Operations and built-in functions that operate on a NaN are not required to return a NaN as the result. The fmin or fmax might not return NaN in cases where the original expression would be required to return NaN. Signed-off-by: Ian Romanick Reviewed-by: Jason Ekstrand --- diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index ef240ae0e91..43b29484319 100644 --- a/src/compiler/nir/nir_opt_algebraic.py +++ b/src/compiler/nir/nir_opt_algebraic.py @@ -168,8 +168,8 @@ optimizations = [ (('flt(is_not_used_by_conditional)', ('fadd(is_used_once)', a, ('fneg', b)), 0.0), ('flt', a, b)), (('fge', ('fneg', ('fabs', a)), 0.0), ('feq', a, 0.0)), - (('bcsel', ('flt', b, a), b, a), ('fmin', a, b)), - (('bcsel', ('flt', a, b), b, a), ('fmax', a, b)), + (('~bcsel', ('flt', b, a), b, a), ('fmin', a, b)), + (('~bcsel', ('flt', a, b), b, a), ('fmax', a, b)), (('~bcsel', ('fge', a, b), b, a), ('fmin', a, b)), (('~bcsel', ('fge', b, a), b, a), ('fmax', a, b)), (('bcsel', ('inot', a), b, c), ('bcsel', a, c, b)),