From: Mike Frysinger Date: Tue, 29 Mar 2011 05:51:22 +0000 (+0000) Subject: gas: blackfin: gas: blackfin: reject invalid BYTEOP16M insns X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=3823a07437e70105c9a11fbddddb8273e1b8a858;p=binutils-gdb.git gas: blackfin: gas: blackfin: reject invalid BYTEOP16M insns The destination registers must be different with BYTEOP16M insns, otherwise the hardware throws up an exception. So reject them. Signed-off-by: Mike Frysinger --- diff --git a/gas/ChangeLog b/gas/ChangeLog index 428d26663b8..5ae246e5eca 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,8 @@ +2011-03-29 Mike Frysinger + + * config/bfin-parse.y (BYTEOP16M): Return yyerror when dest + reg $2 is the same as dest reg $4. + 2011-03-29 Mike Frysinger * config/bfin-parse.y (BYTEOP16P): Return yyerror when dest diff --git a/gas/config/bfin-parse.y b/gas/config/bfin-parse.y index 12e752584c2..7961e2e031f 100644 --- a/gas/config/bfin-parse.y +++ b/gas/config/bfin-parse.y @@ -849,6 +849,8 @@ asm_1: { if (!IS_DREG ($2) || !IS_DREG ($4)) return yyerror ("Dregs expected"); + else if (REG_SAME ($2, $4)) + return yyerror ("Illegal dest register combination"); else if (!valid_dreg_pair (&$9, $11)) return yyerror ("Bad dreg pair"); else if (!valid_dreg_pair (&$13, $15)) diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog index 24726279b6a..20aeb3fbb86 100644 --- a/gas/testsuite/ChangeLog +++ b/gas/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2011-03-29 Mike Frysinger + + * gas/bfin/expected_errors.s: Add invalid BYTEOP16M insn tests. + * gas/bfin/expected_errors.l: Add new error messages. + 2011-03-29 Mike Frysinger * gas/bfin/expected_errors.s: Add invalid BYTEOP16P insn tests. diff --git a/gas/testsuite/gas/bfin/expected_errors.l b/gas/testsuite/gas/bfin/expected_errors.l index 216c8e141f3..1c12e65f10d 100644 --- a/gas/testsuite/gas/bfin/expected_errors.l +++ b/gas/testsuite/gas/bfin/expected_errors.l @@ -103,3 +103,5 @@ .*:131: Error: Illegal dest register combination. Input text was A0.H. .*:133: Error: Illegal dest register combination. .*:134: Error: Illegal dest register combination. +.*:135: Error: Illegal dest register combination. +.*:136: Error: Illegal dest register combination. diff --git a/gas/testsuite/gas/bfin/expected_errors.s b/gas/testsuite/gas/bfin/expected_errors.s index 677103c9e2b..a671a2cd66a 100644 --- a/gas/testsuite/gas/bfin/expected_errors.s +++ b/gas/testsuite/gas/bfin/expected_errors.s @@ -132,3 +132,5 @@ (R0, R0) = BYTEOP16P (R1:0, R3:2); (R7, R7) = BYTEOP16P (R1:0, R3:2); + (R1, R1) = BYTEOP16M (R1:0, R3:2); + (R4, R4) = BYTEOP16M (R1:0, R3:2);